Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - Improve playground error message #1420

Closed
wants to merge 43 commits into from
Closed

Enhancement - Improve playground error message #1420

wants to merge 43 commits into from

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Mar 5, 2024 •
edited
Loading

Description

This PR improves the error messages in the playground for different feature flags.

Related Issue

Closes #885

Related PR

Closes #197_cloud

aybruhm and others added 30 commits December 1, 2023 19:40
@aybruhm
Update - improve playground error message
d4e75d8
@aybruhm
Refactor - clean up view navigation component
33f2493
@bekossy
format fix
ab99363
@bekossy
Merge branch 'main' into gh/issue-885-resolve
0f45864
@aybruhm
Update - improve playground error message
3820110
@aybruhm
Feat - created cli app_logs command module
9537585
@aybruhm
Update - register app_logs command to cli
319848e
@aybruhm
Feat - created retrieve_app_logs cli client
956f208
@aybruhm
Update - created get_app_logs router skeleton
2ba848e
@aybruhm
Cleanup - arrange imports
f204f46
@aybruhm
Refactor - renamed app_logs to variant_logs
339a233
@aybruhm
Refactor - renamed retrieve_app_logs to retrieve_variant_logs
5fe61c7
@aybruhm
Feat - implemented retrieve variant logs api router
0e71231
@aybruhm
Feat - implemented retrieve cloudwatch logs function
877be34
@aybruhm
🎨 Format - ran black and format-fix
253029a
@aybruhm
Update - modified retrieve_cloudwatch_logs function
19e4862
@aybruhm
Update - created get_deployment_by_appId db function
ad0f1b5
@aybruhm
Update - modified get_variant_logs_stream function
86ba72b
@aybruhm
Update - add different error messages based on feature-flag
73ebda9
@aybruhm
🎨 Format - ran prettier --write .
cd64de6
@aybruhm
Update - created isCloud and isEnterprise utils function
6556116
@aybruhm
Update - include region_name to logs_manager boto client
2558688
@aybruhm
Update - modified error message for cloud users
385d2e6
@aybruhm
Update - include return type to get_app_variant_instance_by_id db fun…
84ffae0 
…ction
@aybruhm
Refactor & Cleanup - modified process (cli->client->backend) to retri…
365f1ce 
…eve variant function logs
@aybruhm
Refactor - move logs_manager to cloud/services/ and sync changes
58005a4
@aybruhm
Update - clean up retrieve_variant_logs api router
c19bcb7
@aybruhm
🎨 Format - ran black
0ab8b58
@aybruhm
Update - modified retrieve_variant_logs api router
a0ac49e
@aybruhm
Update - refactor messages in click.style(...)
7d58ab4
@aakrem
Copy link
Collaborator

aakrem commented Mar 5, 2024

@aybruhm 1 check is failing

@aybruhm aybruhm requested a review from aakrem March 12, 2024 12:09
aakrem
aakrem requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Not working
Screenshot 2024-03-26 at 17 00 31
  1. Same comment from the older PR
    Enhancement - Improve playground error message and introduce new CLI command for cloudwatch logs #984 (comment)

@aybruhm
Copy link
Member Author

aybruhm commented Mar 26, 2024

  1. Not working
Screenshot 2024-03-26 at 17 00 31 2. Same comment from the older PR [Enhancement - Improve playground error message and introduce new CLI command for cloudwatch logs #984 (comment)](https://github.com//pull/984#issuecomment-1853885329)

Oh, I see. The issue is with the cli backend client. The last time the backend client was generated, we had the client logic located in agenta-cli/agenta/client/client.py. Now we have it in agenta-cli/agenta/client/backend/client.py, which also has the following structure based on the API tags:.

image

I'll regenerate the cli backend client later today and update the PR. Thanks for catching that.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 5, 2024
@vercel Vercel
Copy link

vercel bot commented May 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2024 0:44am

@aybruhm
Copy link
Member Author

aybruhm commented May 5, 2024

I removed the cli command to retrieve the variant logs. I believe that the viewing experience for the logs is much better directly on the playground than on the cli. Here's what it looks like on the playground:

image

cc: @mmabrouk, @aakrem

@aybruhm aybruhm closed this May 5, 2024
@aybruhm aybruhm mentioned this pull request May 5, 2024
Merged
@aybruhm
Copy link
Member Author

aybruhm commented May 5, 2024

PR became redundant due to the misleading commit messages. You can find the new PR here: #1611

@bekossy bekossy deleted the gh/issue-885-improve-playground-error-message branch July 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakrem aakrem aakrem requested changes

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Errors when serving a non-functional variant due to null deployment
3 participants
@aybruhm @aakrem @bekossy